Bug 117537 - [CSS Blending] Add test suite to validate Background Layers Blending
Summary: [CSS Blending] Add test suite to validate Background Layers Blending
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108546
  Show dependency treegraph
 
Reported: 2013-06-12 05:01 PDT by Mihai Tica
Modified: 2013-06-13 11:34 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.48 MB, patch)
2013-06-12 05:14 PDT, Mihai Tica
no flags Details | Formatted Diff | Diff
Patch (1.48 MB, patch)
2013-06-12 10:56 PDT, Mihai Tica
no flags Details | Formatted Diff | Diff
Removing the dynamic test, as it's now included in https://bugs.webkit.org/show_bug.cgi?id=117223 (1.48 MB, patch)
2013-06-12 23:44 PDT, Mihai Tica
no flags Details | Formatted Diff | Diff
Updated patch (1.11 MB, patch)
2013-06-13 07:00 PDT, Mihai Tica
no flags Details | Formatted Diff | Diff
Patch (1.12 MB, patch)
2013-06-13 10:49 PDT, Mihai Tica
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Tica 2013-06-12 05:01:25 PDT
CSS Background Blending should be performed, regardless the background layer possible combinations.
As a first step of validating the feature, tests should be added for the following use cases:

1. Bg blend mode for an element with just one image as the background.
2. Bg blending for an image and a background color. Different background images should be tested, having different formats, such as png or jpg.
3. Bg blending for a gradient and a background color.
4. Bg blending for a gradient on top of an image.
5. Bg blending for an image on top of a gradient.
6. Bg blending for a gradient on top of another gradient. 
7. Bg blending for an image on top of another image. 
8. Bg blending for an image on top of a background color. 
9. Blend multiple background layers (3 images, for example).
10. Blend 3 background images, specify less blend modes in CSS.
11. Change the background blending mode of an element from script.
Comment 1 Mihai Tica 2013-06-12 05:14:37 PDT
Created attachment 204426 [details]
Patch
Comment 2 Dean Jackson 2013-06-12 10:18:19 PDT
Comment on attachment 204426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204426&action=review

> LayoutTests/css3/compositing/background-blend-mode-default-value.html:16
> +<!-- Test wether default blend mode values are set for the unspecified layers in -webkit-background-blend-mode. -->

Typo: whether.

> LayoutTests/css3/compositing/background-blend-mode-different-image-formats.html:25
> +<!-- This file should contain a two divs that should perform blending with the background color.-->

Typo: "contain two"

> LayoutTests/css3/compositing/background-blend-mode-image-color-dynamic.html:19
> +        if (window.testRunner) {
> +            window.testRunner.waitUntilDone();
> +        }

No braces needed
Comment 3 Mihai Tica 2013-06-12 10:56:52 PDT
Created attachment 204457 [details]
Patch
Comment 4 Mihai Tica 2013-06-12 11:03:39 PDT
Thanks for the review, I've attached a rebased version wich also includes the addressed comments
Comment 5 Mihai Tica 2013-06-12 23:44:20 PDT
Created attachment 204556 [details]
Removing the dynamic test, as it's now included in https://bugs.webkit.org/show_bug.cgi?id=117223
Comment 6 Mihai Tica 2013-06-13 07:00:51 PDT
Created attachment 204582 [details]
Updated patch
Comment 7 Mihai Tica 2013-06-13 07:02:12 PDT
(In reply to comment #6)
> Created an attachment (id=204582) [details]
> Updated patch

This patch no longer includes the tests attached to gradient blending at https://bugs.webkit.org/show_bug.cgi?id=117532
Comment 8 Dirk Schulze 2013-06-13 07:53:13 PDT
Comment on attachment 204582 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204582&action=review

> LayoutTests/ChangeLog:12
> +        * css3/compositing/background-blend-mode-default-value-expected.txt: Added.

The empty text files look weird. Are you sure they are needed?
Comment 9 Mihai Tica 2013-06-13 09:52:27 PDT
(In reply to comment #8)
> (From update of attachment 204582 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204582&action=review
> 
> > LayoutTests/ChangeLog:12
> > +        * css3/compositing/background-blend-mode-default-value-expected.txt: Added.
> 
> The empty text files look weird. Are you sure they are needed?

It does make sense to dump them, however, I've deleted them on my machine, and the tests failed on the first run, while passing on the consequent run.

It's not clear to me, would removing them from the patch actually make it fail on the try machine?
Comment 10 Mihai Tica 2013-06-13 10:49:44 PDT
Created attachment 204630 [details]
Patch
Comment 11 Mihai Tica 2013-06-13 10:52:31 PDT
(In reply to comment #9)
> (In reply to comment #8)
> > (From update of attachment 204582 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=204582&action=review
> > 
> > > LayoutTests/ChangeLog:12
> > > +        * css3/compositing/background-blend-mode-default-value-expected.txt: Added.
> > 
> > The empty text files look weird. Are you sure they are needed?
> 
> It does make sense to dump them, however, I've deleted them on my machine, and the tests failed on the first run, while passing on the consequent run.
> 
> It's not clear to me, would removing them from the patch actually make it fail on the try machine?

With this patch, I've removed the testRunner.dumpAsText calls.
Comment 12 Dirk Schulze 2013-06-13 11:00:54 PDT
Comment on attachment 204630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204630&action=review

r=me

> LayoutTests/ChangeLog:6
> +        This patch set removes the test case of adding bg blend mode through script, as it
> +        is now part of bug#117223

You are not removing anything in this patch. Will that be part of a followup, or do we keep both tests alive? Anyway. LGTM.
Comment 13 Mihai Tica 2013-06-13 11:06:08 PDT
(In reply to comment #12)
> (From update of attachment 204630 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204630&action=review
> 
> r=me
> 
> > LayoutTests/ChangeLog:6
> > +        This patch set removes the test case of adding bg blend mode through script, as it
> > +        is now part of bug#117223
> 
> You are not removing anything in this patch. Will that be part of a followup, or do we keep both tests alive? Anyway. LGTM.

My fault, what I meant was that I moved the script test from this patch to the other mentioned bug.
Comment 14 WebKit Commit Bot 2013-06-13 11:34:40 PDT
Comment on attachment 204630 [details]
Patch

Clearing flags on attachment: 204630

Committed r151567: <http://trac.webkit.org/changeset/151567>
Comment 15 WebKit Commit Bot 2013-06-13 11:34:42 PDT
All reviewed patches have been landed.  Closing bug.