Bug 76498 - [chromium] Apply color profiles in more cases
Summary: [chromium] Apply color profiles in more cases
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
Depends on: 75999
Blocks: 82428
  Show dependency treegraph
Reported: 2012-01-17 17:03 PST by Kenneth Russell
Modified: 2012-03-28 20:54 PDT (History)
4 users (show)

See Also:

Patch (1.79 KB, patch)
2012-01-17 17:10 PST, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2012-01-17 17:03:17 PST
The fix for Bug 75999 disabled the application of color profiles whenever WebGL's premultipliedAlpha flag is set. We can do better than this if we check to see whether the image has an alpha channel before deciding not to apply the color profile.
Comment 1 Kenneth Russell 2012-01-17 17:10:45 PST
Created attachment 122843 [details]
Comment 2 Stephen White 2012-01-17 17:30:31 PST
Comment on attachment 122843 [details]

I'm not very familiar with this code, but I'll trust the test results.  r=me
Comment 3 noel gordon 2012-01-17 17:43:47 PST
Comment 4 WebKit Review Bot 2012-01-17 19:09:33 PST
Comment on attachment 122843 [details]

Clearing flags on attachment: 122843

Committed r105230: <http://trac.webkit.org/changeset/105230>
Comment 5 WebKit Review Bot 2012-01-17 19:09:37 PST
All reviewed patches have been landed.  Closing bug.